ljharb | 24 Pull Requests

I could also hoist up the actualDeleteCount logic, and get rid of the if/elseif/else chain entirely, but I'm not as convinced that one would be an improvement.

Noticed this while reviewing/implementing https://tc39.es/proposal-change-array-by-copy/#sec-array.prototype.toSpliced

Contributed to Array.prototype.groupBy 2021-12-14 22:41:00 UTC

Published an official polyfill

Contributed to a bunch of them 2021-12-11 14:28:00 UTC

updated a ton of projects; see commits referenced here https://github.com/inspect-js/is-arguments/pull/38

Contributed to a bunch more 2021-12-12 14:28:00 UTC

updated a ton of projects; see commits referenced here https://github.com/inspect-js/is-arguments/pull/38

spec: fix typo to tc39/proposal-array-from-async 2021-12-14 18:58:04 UTC

I assume syncItems is meant to be asyncItems here?

[arborist] [refactor] `Shrinkwrap`: add `toJSON` method to get shrinkwrap file contents without saving to npm/cli 2021-12-18 06:12:43 UTC

This allows me to build a tool that gets the lockfile's contents without touching the filesystem.

Remove harmful stage 1 polyfill recommendation to tc39/process-document 2021-12-17 21:48:40 UTC

It seems that this document is inadvertently recommending that folks publish polyfills in stage 1, which is incredibly dangerous for web compat, rather than in stage 3, which is the appropriate time.

This PR does not change any stage advancement criteria; in spec lingo, it is editorial, not no...

util: refactor addNumericSeparator logic to nodejs/node 2021-12-16 22:41:26 UTC

I noticed in #41003 that the loop-slice logic in addNumericSeparator could be done with a single regex replace.

I did not change the implementation of addNumericSeparatorEnd because the logic is slightly different, but I can try to do that if desired.

util: display a present-but-undefined error cause to nodejs/node 2021-12-19 23:34:01 UTC

See https://github.com/nodejs/node/pull/41097#issuecomment-997055761

It was a very explicit and intentional decision to differentiate an undefined cause from an absent cause, so let's display it.

[New] add `PropTypes.bigint` to facebook/prop-types 2021-12-22 21:29:36 UTC

Closes #355.

Once tests pass, I'll merge this.

[Tests] do not fail fast; add react 17 to facebook/prop-types 2021-12-23 06:18:04 UTC

Doing this as a PR to make sure CI passes first.

[Tests] minimize test output to yannickcr/eslint-plugin-react 2018-12-03 07:03:49 UTC

Contributed to eslint-plugin-react 2018-12-03 12:00:00 UTC

Triaged issues.

[Dev Deps] update `eslint` etc to airbnb/enzyme 2018-12-02 07:57:39 UTC

[Fix] use function name inference and computed properties to distinguish `Symbol()` from `Symbol(‘’)`, when available to es-shims/Symbol.prototype.description 2017-12-01 08:41:39 UTC

Fixes #1.

cc @bakkot @michaelficarra

[Deps] use `array.prototype.flatten` to airbnb/react-with-styles-interface-css 2017-12-12 07:23:00 UTC

Tests don't seem to cover this, but this seems right to me?

`nvm use`: perfect pre-npm-config env var checking to creationix/nvm 2017-12-05 08:01:46 UTC

@zkat @iarna: I would dearly love your input on this change; if this env var checking is good, then I can next replace npm config get prefix with "searching .npmrc files", which will give nvm a huge performance boost.

Move "length" checks of the receiver so they happen before argument checks to tc39/proposal-flatMap 2017-12-08 21:38:45 UTC

From #49.

[Tests] Years only have 12 months, and these tests started failing in December to airbnb/react-dates 2017-12-04 07:23:44 UTC

If there's a more robust way to do these comparisons, I'm happy to switch to that.