I had done most of the work necessary to use esbuild to correctly load hbs
or gjs
files in #1650 but I forgot to add the correct config to the optimizeDeps()
helper function.
This PR fixes that 💪
This is to make sure that #1698 is now also on the main branch 👍
A CI job died because yarn is hoisting wrong 🙈 https://github.com/ember-codemods/ember-angle-brackets-codemod/actions/runs/7099310681/job/19323069721
I am moving to pnpm to avoid this in future 👍
This was accidentially removed in #29 because of an overly-aggressive lint --fix
🙈
I just ran run npm init release-plan-setup --update
to get the latest copy of the release plan workflows: https://github.com/mansona/create-release-plan-setup/releases/tag/v1.2.0-create-release-plan-setup
There was a bit of a race condition where you would get a new PR opened just after you release because release-plan was running at the same time as the publish job.
This PR changes it so that the PR is only created when you haven't update .release-plan.json
i.e. are not doing a release 👍
A CI job died because yarn is hoisting wrong 🙈 https://github.com/ember-codemods/ember-angle-brackets-codemod/actions/runs/7099310681/job/19323069721
I am moving to pnpm to avoid this in future 👍
This was accidentially removed in #29 because of an overly-aggressive lint --fix
🙈
I just ran run npm init release-plan-setup --update
to get the latest copy of the release plan workflows: https://github.com/mansona/create-release-plan-setup/releases/tag/v1.2.0-create-release-plan-setup
There was a bit of a race condition where you would get a new PR opened just after you release because release-plan was running at the same time as the publish job.
This PR changes it so that the PR is only created when you haven't up...
<!-- Thank you for submitting a pull request!
Please verify that:
Backlog
milestone (required)main
branchhereby runtests
locallyThis allows you to be able to specify links with a source and a destination
i.e.
--links=some-custom-folder:tests/acceptance
this was just a hard-coded path from when I was hacking the tool together.
Nothing to see here 🙈
I'm in the middle of implementing https://github.com/empress/field-guide/issues/50 and it struck me that it's a bit odd that we call the yaml pages.yml
and not toc.yml
🤔 so I thought we should at least support both 🤷
This PR adds that support
because field-guide is awesome 🎉
This updates ember-body-class to get the fix for latest fastboot https://github.com/mansona/ember-body-class/pull/45
This is just to test a branch on the empress-blog-ember-template to see if I have fixed issues with comments
looking at the instructions for embedding the comments, it seems like our code was very outdated. I can't find a reference for when this was the right way to do it so I don't know how out of date it is 🤔
this fixes a JS error caused by having an invalid author id in the list of authors
I am surprised that we needed to do this 🤔 I would have expected that the CORS implementation would not even be initiated if the origin is not provided but there you go.
Essentially what is happening right now is we are rejecting a simple request with no origin because it doesn't have an origi...
This PR is an extension of the work done in https://github.com/ember-learn/ember-website/pull/84 by @abhilashlr
I had mentioned that #84 was "blocked by #102" but I wasn't very clear what I meant by that 🙈 I wanted to actually convert the PR to be using Ember-Data the same way that #102 was u...
There were some issues loading images on the ember-users page when running this app locally. I have a feeling we were working around a bug that was actually fixed upstream.
I want us to test the deploy-preview app to make sure this is working right before we merge 👍
This is a bit of a rudimentary implementation (that does actually work) designed to spark some conversation about the right way to achieve this same thing.
Currently, with these changes active I am able to make this request:
curl 'http://localhost:3000/api/branches'
and get th...
This may be a bit of a naive fix but it happens to work 😂 I've tested this locally by linking all the things and it's working as expected
<img width="509" alt="screenshot 2018-12-13 at 11 00 24" src="https://user-images.githubusercontent.com/594890/49934664-e3956a80-fec6-11e8-89ea-dd78e5f5be5d.png">
This implementation was already there, it just was accessing the wrong location of the session user (user.attributes
instead of...
Fixes #294
Fixes https://github.com/aws-amplify/amplify-cli/issues/562
Adds Ember to the list of frontend frameworks when running amplify init
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Nothing major to see here, just getting you on the latest version of stuff 👍
This will now fail CI if there are issues with the pages.yml
file or any of the internal links in the markdown 👍
Howdy folks 👋
This is essentially an extension of my work on https://github.com/retextjs/retext-profanities/pull/17 that is attempting to allow you to configure the level of "sureness" that a word is profane.
This is also a "speculative" PR on how I think we might be able to expose this l...
We originally added the catalog
component and route to the deck project for ease of development. As we are now looking at building other apps using cardstack it makes sense for us to share the carstack-catalog helper component between instances.
I have this working on a new project by just d...
This is a relatively small PR that allows the end user to define a "minimum sureness" config value. For example, if you do not want to have errors/warnings for things that are defined as "0 sureness" from cuss then you can add the following config:
retext()
.use(english, {sureness: ...
The server is not actually broken, it's just throwing the wrong kind of error in a case where the origin is not provided in the request.
This will cause the CORS failures to work correctly in browsers 👍
I'm not 100% sure why this happened 🤔
I was able to recreate this locally and this fixes it for me
This implementation is significant enough that it deserves its own task list! This is to be considered a WIP and should not be merged before all the blocker tasks are done.
{{outlet}}
are still getting highlighted. Maybe write our own hbs plugin for Prism...This is only a proof of concept to see if you are happy with the idea, and if so we can extend it to all/any of the parameters you want to be able to set the defaults for in config.
The basic idea here is: you have a sensible default set for matchTriggerWidth
on ember-power-select but I need...
Missing template processor
when missing ember-cli-htmlbars in dependecies i.e. it exists in dev-d...This updates guides source to be in sync with the deployed v2.15.0 of the guides. We can choose if we would rather not sync because some of these changes are improvements 👍
I figured out the checkout that is currently deployed is: https://github.com/emberjs/guides/commit/b77a3027d161eca3a...
I'm just creating this quick PR to see if you would be open to the idea of upgrading to Javascript. It's a very nieve implementation using decaffeinate.
According to https://github.com/newrelic/node-newrelic/blob/master/Migration%20Guide.md you don't seem to be using any functions that were changed between the 1.x and 2.x versions of node-newrelic so this should be a simple upgrade 👍
I would recommend once it is merged that it is released as...
Howdy 👋
This is a quick implementation of the clear
feature from https://github.com/dixieio/redux-json-api/issues/24
We ended up going for the style closer to { clear: 'explicitName' }
for simplicity. This is because of the structure of JSON:API and the way the data payload can come b...