This makes the function a bit more generic and reduces our reliance on Bytes
. Instead of using .body(Bytes::new())
we can now use .body("")
which shrinks the code a bit. .body(())
is unfortunately not possible yet (see https://gi...
We discovered in https://github.com/embroider-build/embroider/pull/1714 that the types weren't being discovered in projects that are relying on node10 moduleResolution. @SergeAstapov came to our rescue and suggested this change 🎉
I'm not exactly sure why typescript can't find the types from the new version of scenario-tester 🤔 anyone have any clues?
I ran npx create-release-plan-setup@latest --update
to update to the latest and greatest release-plan setup 👌
This also fixes a bug that would prevent us from actually doing a release once we merge 🎉
<!-- Thank you for your Pull Request. Please provide a description above and review the requirements below.
Bug fixes and new features should include tests.
Contributors guide: https://github.com/tokio-rs/axum/blob/master/CONTRIB...
The middleware that is responsible for rejecting requests without a User-Agent
header runs after the middleware that logs requests. The request logging middleware however was expecting a TypedHeader<UserAgent>
, which meant that reque...
I kinda assumed that the previous version of this would implicitly use the CWD but apparently I was wrong 🤷
Looks like the two layers above it aren't actually necessary 🤷♂️
We really shouldn't need this but for some reason the output of pnpm m ls --json --depth=-1
without this is:
[
{
"name": "release-plan",
"version": "0.5.0",
"path": "/Users/mansona/git/opensource/release-pl...
for the addon-blueprint one of the packages that we want to deploy is the root package, and it was using a glob for the package list
This PR adds a sample fixture that matches the ...
This PR upgrades our projects to axum 0.7 and hyper 1.x.
The changes on the axum side are described by https://tokio.rs/blog/2023-11-27-announcing-axum-0-7-0
Unfortunately there appears to be no way to adopt most of these breaking ...
It looks like the repository got move to another GitHub org...
see https://github.com/smithy-lang/smithy-rs
I had done most of the work necessary to use esbuild to correctly load hbs
or gjs
files in #1650 but I forgot to add the correct config to the optimizeDeps()
helper function.
This PR fixes that 💪
A CI job died because yarn is hoisting wrong 🙈 https://github.com/ember-codemods/ember-angle-brackets-codemod/actions/runs/7099310681/job/19323069721
I am moving to pnpm to avoid this in future 👍
There is no need for the _SECONDS
suffix if we use Duration
directly for the const
:)
Having RequestBodyTimeoutLayer
(which changes the Body
type of the Request
) in the middle of the ServiceBuilder
has already been hard to deal with in the past, and does not seem to work anymore with axum 0.7. This change moves th...
In the current situation reqwest
reexports the header code from the http
crate. However once we update hyper
to 1.x we will have two copies of the http
crate, with differing major versions. This leads to conflicts between the hea...
We know the exact status code that we expect, so we might as well use assert_eq!()
instead of the custom matcher implementation.
This was accidentially removed in #29 because of an overly-aggressive lint --fix
🙈
This should make our migration to axum 0.7 and hyper 1.x a little easier since our version of reqwest
is currently not compatible with hyper 1.x.
I just ran run npm init release-plan-setup --update
to get the latest copy of the release plan workflows: https://github.com/mansona/create-release-plan-setup/releases/tag/v1.2.0-create-release-plan-setup
There was a bit of a race condition where you would get a new PR opened just after you release because release-plan was running at the same time as the publish job.
This PR changes it so that the PR is only created when you haven't up...
This should automate the first part of https://ops-guide.crates.io/ops/index-squash.html#manual-work