24 Pull Requests
tvdeyen

tvdeyen

Preferred Languages
Ruby
Member of...
  • AlchemyCMS
  • solidusio
  • solidusio-contrib
tvdeyen has made 6 contributions so far during the 2023 holidays
  • Gifts
  • Contributions
  • 2022
  • 2021
  • 2020
  • 2019
  • 2018
  • 2017
  • 2016
  • 2015
  • 2014
  • 2013
  • 2012
  1. > 12/ 1 Add a new picture thumbnail style
  2. > 12/ 2 Use Remix icons
  3. > 12/ 3 Revert "Optimize events on handler"
  4. > 12/ 4 Add support for RailsLiveReload
  5. > 12/ 5 UI Refinements
  6. > 12/ 6 Use shoelace/tooltip for all button_with_label
  7. > 12/ 7
  8. > 12/ 8
  9. > 12/ 9
  10. > 12/ 10
  11. > 12/ 11
  12. > 12/ 12
  13. > 12/ 13
  14. > 12/ 14
  15. > 12/ 15
  16. > 12/ 16
  17. > 12/ 17
  18. > 12/ 18
  19. > 12/ 19
  20. > 12/ 20
  21. > 12/ 21
  22. > 12/ 22
  23. > 12/ 23
  24. > 12/ 24
  25. > 12/ 25 Happy Holidays

UI Refinements to AlchemyCMS/alchemy_cms 2023-12-09 20:47:20 UTC

What is this pull request for?

  • Fix sitemap icons
  • Exchange page_status and page_infos partial names
  • Remove hint tooltip from page status icons
  • Remove page hint from toolbar
  • Lower table row height
  • Fix current page tab alignment
  • Use flexbox for select_with_label positioning...

Use shoelace/tooltip for all button_with_label to AlchemyCMS/alchemy_cms 2023-12-09 20:34:04 UTC

What is this pull request for?

Using shoelaces tooltip web component gives us:

  • Better placement
  • More accessibility
  • Lesser code to maintain

Introduces a toolbar_button class that is responsible for the margin in toolbars.

Checklist

  • [x] I have followed [Pull Request gui...

Add support for RailsLiveReload to AlchemyCMS/alchemy_cms 2023-12-08 18:08:05 UTC

What is this pull request for?

Automatically reloads the dummy app (or any other app that has rails_live_reloadgem installed) if changes to Alchemy files have been made.

Revert "Optimize events on handler" to AlchemyCMS/alchemy_cms 2023-12-05 19:09:52 UTC

The targets might not yet be present in the DOM during initialization. Delegating to the time of the event fixes issues with the node tree.

This reverts commit 006454a18b4776f1cd3da8c3a4e5a90e59bfc799.

Use Remix icons to AlchemyCMS/alchemy_cms 2023-12-05 08:47:08 UTC

What is this pull request for?

Describe you pull request here...

Closes #<issue number> (Remove if not related to any issue)

Notable changes (remove if none)

Explain any changes (maybe breaking?) that have been made.

Screenshots

Remove if no visual changes have been m...

Add a new picture thumbnail style to AlchemyCMS/alchemy_cms 2023-12-04 09:53:14 UTC

What is this pull request for?

Slightly updates the look of pictures in the archive and element editor to reduce the boxy visual clutter.

Screenshots

Alchemy CMS - Images ![gallery-ima...

WIP Add anchors feature for ingredients to AlchemyCMS/alchemy_cms 2022-12-12 19:56:40 UTC

What is this pull request for?

Describe you pull request here...

Closes #<issue number> (Remove if not related to any issue)

Notable changes (remove if none)

Explain any changes (maybe breaking?) that have been made.

Screenshots

Remove if no visual changes have been m...

Remove old jasmine based javascript specs to AlchemyCMS/alchemy_cms 2022-12-14 14:49:41 UTC

They have not been used in ages and we have Jest specs nowadays.

Checklist

  • [x] I have followed Pull Request guidelines
  • [x] I have added a detailed description into each commit message

Update bundled Tinymce to 4.9.11 to AlchemyCMS/alchemy_cms 2022-12-14 14:48:16 UTC

What is this pull request for?

Also fixes the links to icons used in the tinymce editor iframe.

Checklist

  • [x] I have followed Pull Request guidelines
  • [x] I have added a detailed description into each commit m...

Add Headline size and level selects as input addons to AlchemyCMS/alchemy_cms 2022-12-14 14:28:24 UTC

What is this pull request for?

Instead of having a second row in the editor we stick with our theme of a single input per ingredient by adding the selects as an input addons. A commonly known UI element.

Screenshots

<img alt="headline-size-select" src="https://user-images.github...

Add dom_id attribute to ingredient headline and text serializers to AlchemyCMS/alchemy-json_api 2022-12-15 16:21:49 UTC

dom_id attribute is introduced in https://github.com/AlchemyCMS/alchemy_cms/pull/2395

Migrate to Vuepress v2 to AlchemyCMS/alchemy-guides 2022-12-22 14:17:43 UTC

Theme fixes to AlchemyCMS/alchemy-guides 2022-12-22 18:50:27 UTC

| AlchemyCMS 2022-12-22 19-50-17

CI: Update brakeman scan to AlchemyCMS/alchemy_cms 2022-12-06 19:49:14 UTC

Use ruby/setup-ruby action Update to latest brakeman

Fix page seeder to AlchemyCMS/alchemy_cms 2022-12-06 17:47:24 UTC

What is this pull request for?

If you pass a public_on date to the page seeder, Alchemy will create a public version (because of the public_on= attribute writer). The before_create filter kicks in too late, leading to public pages without a draft version.

Tried to use different bef...

fix(Address): Set name from firstname and lastname on update to solidusio/solidus 2021-12-16 11:35:13 UTC

If use_combined_first_and_last_name_in_address is false (default) and firstname and lastname are given in the changeset (ie. from a form) we need to make sure that name is set from it, otherwise data will be inconsistent.

Closes #4094

Description <!-- Please include a summary of t...

Revert 21300973408b1b02b67d7d05cffaccab8c6d489c to solidusio/solidus 2021-12-16 11:45:21 UTC

In Solidus v2.11 we still use false for this setting. Using true in specs per default is giving false positives and issues like #4094 where not found.

Description <!-- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and con...

Add filter and pagination to tax rates admin view to solidusio/solidus 2021-12-13 20:00:27 UTC

Description

Managing a lot of tax rates is currently not very user friendly.

Adding pagination, filtering by zone and tax category and a default order by zone makes managing tax much nicer. And who does not love managing taxes.

Screenshots

<img alt="Tax Rates - Taxes - Setti...

Fix admin promotion adjustments spec to solidusio/solidus 2017-12-01 20:57:37 UTC

After the merge of https://github.com/solidusio/solidus/pull/2394 the admin promotion adjustment spec that got introduced by https://github.com/solidusio/solidus/pull/2400 broke.

Use I18n date format for `pretty_time` helper to solidusio/solidus 2017-12-01 14:17:09 UTC

Instead of concatenating strings we should use a i18n date format instead.

Also introduces support for custom Solidus' time formats. Currently we are using the Rails :long date format that Rails apps and extensions might override. Instead we use our own solidus namespace to avoid conflic...

[RFC] Use nested checkboxes and radio buttons all over admin to solidusio/solidus 2017-12-04 08:53:33 UTC

Following our own styleguide and due to better styleability we should nest checkboxes and radio buttons into their labels.

This also removes some redundant and unused style definitions regarding labels, checkboxes and radio buttons.

The most debatable change might be the label font-size change...

Rescue Braintree void errors and refund instead to solidusio/solidus_paypal_braintree 2017-12-04 14:39:55 UTC

Sometimes Braintree returns a voidable transaction status although it is not voidable anymore.

According to them there is a hidden state called settling that is not returned by the API for a transaction status request.

When we then void we get back an error from the API that leaves the transa...

Use remote transaction status for admin actions to solidusio/solidus_paypal_braintree 2017-12-05 10:55:19 UTC

Solidus usually uses the payment state for deciding if a certain admin action (capture, credit, void) is possible for a payment. Do to the async nature of the web this might get out of sync and leads to payments in a non-actionable state for admins. By asking the Braintree gateway for the current...

Center "no objects found" messages to solidusio/solidus 2017-12-01 22:20:16 UTC

Before we used 9 of 12 columns. This makes no sense and moves all of these messages to the right instead of centering them, would they supposed to be.

Before

no-objects2-before

A...

Touch products when relation gets created/updated to thisisaday/spree_related_products 2017-12-12 16:31:48 UTC

When a product gets related to another product the cache key doesn't get updated. This fixes this by enabling touch option the belongs_to associations.

Rename gem to solidusio-contrib/solidus_stripe 2017-12-07 21:42:39 UTC

Also removes all payment methods besides the Stripe one.

Add payment method parent class to solidusio/solidus_support 2017-12-08 12:53:00 UTC

Add SolidusSupport.payment_method_parent_class

This helps to get the parent class for payment methods.

For Solidus < 2.3 it is Spree::PaymentMethod for non credit card payment methods or Spree::Gateway for credit card payment methods.

For Solidus >= 2.3 it is Spree::PaymentMethod...

Remove duplicated user extension requires to AlchemyCMS/alchemy-solidus 2017-12-22 20:51:58 UTC

We only want to load the user extension we need for the selected user class.

Store credit admin UI fixes to solidusio/solidus 2017-12-01 22:51:35 UTC

Before

store credit - admin example com - users 2017-12-01 23-44-25

![edit - store credit - store credits - admin example com - users 2017-12-01 23-45-29](https://user-images.githubuser...

Mention compatible Solidus and Alchemy versions to AlchemyCMS/alchemy-solidus 2017-12-22 11:46:53 UTC

[Spree 2.4] Touch products when relation gets created/updated to thisisaday/spree_related_products 2017-12-12 16:43:56 UTC

When a product gets related to another product the cache key doesn't get updated. This fixes this by enabling touch option the belongs_to associations.

Add an integration spec to AlchemyCMS/alchemy-solidus 2017-12-22 23:27:33 UTC

Includes #19

Add an install generator to AlchemyCMS/alchemy-solidus 2017-12-22 23:13:50 UTC

Make the install generator idempotent to solidusio/solidus 2017-12-22 23:23:44 UTC

Currently if you run the install generator a second time the

mount Spree::Core::Engine

route gets injected a second time.

Thor's insert_into_file should be an reversible operation but I guess because we inject multiple lines into the routes file it doesn't work as expected.

Remove bottom border of non-form fieldsets to solidusio/solidus 2017-12-01 22:35:39 UTC

We have too many borders in our layout. Whitespace, tables and headers are separating content areas already, no need for additional borders. That only distracts the eye.

Keeps the bottom border for fieldsets that are holding a form. This makes sense as the form buttons sit on top of the bottom...

Fix the status icons in link internal page overlay to AlchemyCMS/alchemy_cms 2016-12-01 21:24:52 UTC

Handlebars assets to AlchemyCMS/alchemy_cms 2016-12-02 08:28:46 UTC

Prerequisite for #1202

Nested elements support to AlchemyCMS/alchemy-pg_search 2016-12-05 12:30:07 UTC

Respect descending elements by searching a page and displaying search results.

Configurable pagination to AlchemyCMS/alchemy-pg_search 2016-12-14 14:24:52 UTC

The search results are paginated by 10 per page.

This uses the new config module to let this be configured by:

Alchemy::PgSearch.config = {
  paginate_per: 20
}

or even completely disabled with:

Alchemy::PgSearch.config = {
  paginate_per: nil
}

Add a new spinner animation to AlchemyCMS/alchemy_cms 2016-12-01 21:51:03 UTC

Removes the old spin.js library and add a svg/css based spinner that's build of the Alchemy icon.

alchemy spinner

Remove the stand alone installer to AlchemyCMS/alchemy_cms 2016-12-19 13:20:49 UTC

The stand alone installer mainly creates a rails app and adds the gem into the gemspec, then runs the installer rake task.

This is often cause of bugs and is something we don't want to maintain anymore.

Create instead attachment in essence file spec to AlchemyCMS/alchemy_cms 2016-12-19 13:41:44 UTC

Only stubbing it does not work because in the shared example we access the database.

Factory Girl 4.8.0 complained about and was totally right.

Fix codeclimate 3.4 to AlchemyCMS/alchemy_cms 2016-12-22 08:16:27 UTC

like for master and 3.5 now also for 3.4

Allow any number of arguments on touch method to AlchemyCMS/alchemy_cms 2016-12-23 09:29:44 UTC

We override active records touch method.

We don't need any of the arguments passed into that method. Rails 5 introduces some additional attributes. In order to be save while upgrading we should change the signature to something more reliable here.

Set a blank value for required page attribute to AlchemyCMS/alchemy_cms 2016-12-23 08:56:01 UTC

include_blank must not be false for required attributes.

See https://github.com/plataformatec/simple_form/issues/1427 for further infos

Allow to globally silence deprecations to AlchemyCMS/alchemy_cms 2016-12-23 09:03:50 UTC

In order to be able to silence ActiveSupport::Deprecations globally we need to store the current value instead of blindly setting it to false after some examples.

Enable cache_classes in test env to AlchemyCMS/alchemy_cms 2016-12-23 08:32:46 UTC

This is the default for test env anyway, is the default on production envs and should even speed up the test suite slightly.

Expect full mime type string instead of abbreviation to AlchemyCMS/alchemy_cms 2016-12-23 08:25:34 UTC

Rails 5 now returns full mime type string instead of abbreviated symbol.

Clean up require path to AlchemyCMS/alchemy_cms 2016-12-23 11:06:25 UTC

We currenlty require every dependency in engine.rb. That is cumbersome and should live in Ruby gems default require LOAD_PATH lib/alchemy_cms.rb

Prevent nil asset source errors in essence picture view spec to AlchemyCMS/alchemy_cms 2016-12-23 14:03:33 UTC

Permit parameters in render_tag_list helper to AlchemyCMS/alchemy_cms 2016-12-23 13:56:38 UTC

The parameters passed to the url helper in render_tag_list helper are unsanitzed.

Although considered harmless (we are in the protected admin namespace), Rails 5 raises errors if these aren't sanitized.

DISCLAIMER:

The whole helper should be refactored into a view object, but since...

Several search query param fixes. to AlchemyCMS/alchemy_cms 2015-12-14 09:03:34 UTC

Since the recently switch to ransack as search, several occurrences of params[:query] where left in the code. This pr renames them to params[:q].

Also fixes the remote search form, that is used, amongst others, in the picture and attachment assignment overlay.

Fixes #897

Try to fix erratic failing page feature spec to AlchemyCMS/alchemy_cms 2015-12-14 21:01:27 UTC

Capybara and travis (╯°□°)╯︵ ┻━┻

Build for Ruby 2.3.0-preview1 to AlchemyCMS/alchemy_cms 2015-12-13 20:28:26 UTC

Ruby 2.3.0 is coming out at christmas, so I think it's time to test it.

4.0/skip the default locale in urls to AlchemyCMS/alchemy_cms 2015-12-15 17:08:33 UTC

Follow up to #811

Don't prepend the default locale

On a multi language site, the default locale should not be included in the url. This can avoid seeing the locale twice (once in the tld and once in the locale)

For example a url that used to look like example.de/de/index now looks ...

Fix image loading event to magiclabs/alchemy_cms 2014-12-05 17:36:46 UTC

Closes #602

Also enables Turbolinks Progress Bar that was introduced with 2.5.0

New EssenceFile content option `only` and `except`. Closes #626 to magiclabs/alchemy_cms 2014-12-05 23:13:35 UTC

You can now pass only and/or except option to EssenceFile content settings. It will not/only load attachments with matching content type.

Example:

contents:

  • name: pdf type: EssenceFile settings: only: pdf

Will only show pdfs in the attachment library overlay. Using except...

Fix module generator. to magiclabs/alchemy_cms 2014-12-05 13:49:45 UTC

fixes #672

Use fixed header for users table to magiclabs/alchemy-devise 2014-12-10 10:31:03 UTC

This adds compatibility with the new sticky resource table headers of current Alchemy 3.1 master

Adds fixed resource table headers to magiclabs/alchemy_cms 2014-12-10 10:27:56 UTC

Resource table header will stay on top of table regardless of scroll position of table.

Also adds a more reduced and flat table header style.

Fix refresh event binding on preview frame. to magiclabs/alchemy_cms 2014-12-10 16:30:39 UTC

Everytime we update an element we bind the load event on preview frame.

This patch removes any load event before binding it again.

Register each essence as has_many association. to magiclabs/alchemy_cms 2014-12-12 11:52:56 UTC

Each class that uses acts_as_essence now creates a has_many association on Page and Element classes.

i.e: EssenceText creates a essence_texts association

Do not raise, if page layout could not be found. to magiclabs/alchemy_cms 2014-12-17 14:45:30 UTC

Everytime a page is missing it's page layout definition we raise an error. That is annyoing for site beeing refactored and keeps endusers with an 500 error screen.

This commit changes the behavior into logging a warning and displaying a meaningful warning to the end user. Also the user is now ...

Alchemy version fixes to magiclabs/alchemy-usermanual 2013-12-19 08:30:56 UTC

  • Sponsored by  DNSimple,  Octobox &  Bugsnag
  • About
  • How to contribute?
  • API
  • Unsubscribe
    •  English
    •  Español
    •  Ελληνικά
    •  Português do Brasil
    •  Suomi
    •  Français
    •  Deutsch
    •  Русский
    •  Українська
    •  ไทย
    •  Italiano
    •  Norsk bokmål
    •  தமிழ்
    •  Tr
    •  简体中文
    •  正體中文
    •  日本語
    •  Čeština
    •  हिंदी
    •  Polski
    • Translate into your language!