What is this pull request for?

• Fix sitemap icons
• Exchange page_status and page_infos partial names
• Remove hint tooltip from page status icons
• Remove page hint from toolbar
• Lower table row height
• Fix current page tab alignment
• Use flexbox for select_with_label positioning...

What is this pull request for?

Using shoelaces tooltip web component gives us:

• Better placement
• More accessibility
• Lesser code to maintain

Introduces a toolbar_button class that is responsible for the margin in toolbars.

Checklist

• [x] I have followed [Pull Request gui...

What is this pull request for?

Automatically reloads the dummy app (or any other app that has rails_live_reloadgem installed) if changes to Alchemy files have been made.

The targets might not yet be present in the DOM during initialization. Delegating to the time of the event fixes issues with the node tree.

This reverts commit 006454a18b4776f1cd3da8c3a4e5a90e59bfc799.

What is this pull request for?

Describe you pull request here...

Closes #<issue number> (Remove if not related to any issue)

Notable changes (remove if none)

Explain any changes (maybe breaking?) that have been made.

Screenshots

Remove if no visual changes have been m...

What is this pull request for?

Slightly updates the look of pictures in the archive and element editor to reduce the boxy visual clutter.

Screenshots

![gallery-ima...

What is this pull request for?

Describe you pull request here...

Closes #<issue number> (Remove if not related to any issue)

Notable changes (remove if none)

Explain any changes (maybe breaking?) that have been made.

Screenshots

Remove if no visual changes have been m...

They have not been used in ages and we have Jest specs nowadays.

Checklist

• [x] I have followed Pull Request guidelines
• [x] I have added a detailed description into each commit message

What is this pull request for?

Also fixes the links to icons used in the tinymce editor iframe.

Checklist

• [x] I have followed Pull Request guidelines
• [x] I have added a detailed description into each commit m...

What is this pull request for?

Instead of having a second row in the editor we stick with our theme of a single input per ingredient by adding the selects as an input addons. A commonly known UI element.

Screenshots

<img alt="headline-size-select" src="https://user-images.github...

dom_id attribute is introduced in https://github.com/AlchemyCMS/alchemy_cms/pull/2395

Use ruby/setup-ruby action Update to latest brakeman

What is this pull request for?

If you pass a public_on date to the page seeder, Alchemy will create a public version (because of the public_on= attribute writer). The before_create filter kicks in too late, leading to public pages without a draft version.

Tried to use different bef...

If use_combined_first_and_last_name_in_address is false (default) and firstname and lastname are given in the changeset (ie. from a form) we need to make sure that name is set from it, otherwise data will be inconsistent.

Closes #4094

Description <!-- Please include a summary of t...

In Solidus v2.11 we still use false for this setting. Using true in specs per default is giving false positives and issues like #4094 where not found.

Description <!-- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and con...

Description

Managing a lot of tax rates is currently not very user friendly.

Adding pagination, filtering by zone and tax category and a default order by zone makes managing tax much nicer. And who does not love managing taxes.

Screenshots

<img alt="Tax Rates - Taxes - Setti...

After the merge of https://github.com/solidusio/solidus/pull/2394 the admin promotion adjustment spec that got introduced by https://github.com/solidusio/solidus/pull/2400 broke.

Instead of concatenating strings we should use a i18n date format instead.

Also introduces support for custom Solidus' time formats. Currently we are using the Rails :long date format that Rails apps and extensions might override. Instead we use our own solidus namespace to avoid conflic...

Following our own styleguide and due to better styleability we should nest checkboxes and radio buttons into their labels.

This also removes some redundant and unused style definitions regarding labels, checkboxes and radio buttons.

The most debatable change might be the label font-size change...

Sometimes Braintree returns a voidable transaction status although it is not voidable anymore.

According to them there is a hidden state called settling that is not returned by the API for a transaction status request.

When we then void we get back an error from the API that leaves the transa...

Solidus usually uses the payment state for deciding if a certain admin action (capture, credit, void) is possible for a payment. Do to the async nature of the web this might get out of sync and leads to payments in a non-actionable state for admins. By asking the Braintree gateway for the current...

Before we used 9 of 12 columns. This makes no sense and moves all of these messages to the right instead of centering them, would they supposed to be.

Before

A...

When a product gets related to another product the cache key doesn't get updated. This fixes this by enabling touch option the belongs_to associations.

Also removes all payment methods besides the Stripe one.

Add SolidusSupport.payment_method_parent_class

This helps to get the parent class for payment methods.

For Solidus < 2.3 it is Spree::PaymentMethod for non credit card payment methods or Spree::Gateway for credit card payment methods.

For Solidus >= 2.3 it is Spree::PaymentMethod...

We only want to load the user extension we need for the selected user class.

Before

![edit - store credit - store credits - admin example com - users 2017-12-01 23-45-29](https://user-images.githubuser...

When a product gets related to another product the cache key doesn't get updated. This fixes this by enabling touch option the belongs_to associations.

Includes #19

Currently if you run the install generator a second time the

mount Spree::Core::Engine

route gets injected a second time.

Thor's insert_into_file should be an reversible operation but I guess because we inject multiple lines into the routes file it doesn't work as expected.

We have too many borders in our layout. Whitespace, tables and headers are separating content areas already, no need for additional borders. That only distracts the eye.

Keeps the bottom border for fieldsets that are holding a form. This makes sense as the form buttons sit on top of the bottom...

Prerequisite for #1202

Respect descending elements by searching a page and displaying search results.

The search results are paginated by 10 per page.

This uses the new config module to let this be configured by:

Alchemy::PgSearch.config = {
  paginate_per: 20
}

or even completely disabled with:

Alchemy::PgSearch.config = {
  paginate_per: nil
}

Removes the old spin.js library and add a svg/css based spinner that's build of the Alchemy icon.

The stand alone installer mainly creates a rails app and adds the gem into the gemspec, then runs the installer rake task.

This is often cause of bugs and is something we don't want to maintain anymore.

Only stubbing it does not work because in the shared example we access the database.

Factory Girl 4.8.0 complained about and was totally right.

like for master and 3.5 now also for 3.4

We override active records touch method.

We don't need any of the arguments passed into that method. Rails 5 introduces some additional attributes. In order to be save while upgrading we should change the signature to something more reliable here.

include_blank must not be false for required attributes.

See https://github.com/plataformatec/simple_form/issues/1427 for further infos

In order to be able to silence ActiveSupport::Deprecations globally we need to store the current value instead of blindly setting it to false after some examples.

This is the default for test env anyway, is the default on production envs and should even speed up the test suite slightly.

Rails 5 now returns full mime type string instead of abbreviated symbol.

We currenlty require every dependency in engine.rb. That is cumbersome and should live in Ruby gems default require LOAD_PATH lib/alchemy_cms.rb

The parameters passed to the url helper in render_tag_list helper are unsanitzed.

Although considered harmless (we are in the protected admin namespace), Rails 5 raises errors if these aren't sanitized.

DISCLAIMER:

The whole helper should be refactored into a view object, but since...

Since the recently switch to ransack as search, several occurrences of params[:query] where left in the code. This pr renames them to params[:q].

Also fixes the remote search form, that is used, amongst others, in the picture and attachment assignment overlay.

Fixes #897

Capybara and travis (╯°□°）╯︵ ┻━┻

Ruby 2.3.0 is coming out at christmas, so I think it's time to test it.

Follow up to #811

Don't prepend the default locale

On a multi language site, the default locale should not be included in the url. This can avoid seeing the locale twice (once in the tld and once in the locale)

For example a url that used to look like example.de/de/index now looks ...

Closes #602

Also enables Turbolinks Progress Bar that was introduced with 2.5.0

You can now pass only and/or except option to EssenceFile content settings. It will not/only load attachments with matching content type.

Example:

contents:

• name: pdf type: EssenceFile settings: only: pdf

Will only show pdfs in the attachment library overlay. Using except...

fixes #672

This adds compatibility with the new sticky resource table headers of current Alchemy 3.1 master

Resource table header will stay on top of table regardless of scroll position of table.

Also adds a more reduced and flat table header style.

Everytime we update an element we bind the load event on preview frame.

This patch removes any load event before binding it again.

Each class that uses acts_as_essence now creates a has_many association on Page and Element classes.

i.e: EssenceText creates a essence_texts association

Everytime a page is missing it's page layout definition we raise an error. That is annyoing for site beeing refactored and keeps endusers with an 500 error screen.

This commit changes the behavior into logging a warning and displaying a meaningful warning to the end user. Also the user is now ...