jpbede
Member of...
jpbede has made 11 contributions so far during the 2024 holidays
- > 12/ 1 Add shortcut to open the voice assist dialog
- > 12/ 2 Add device search to quick bar
- > 12/ 3 Mark trend sensor unavailable when source entity is unknown/unavailable
- > 12/ 4 Add new shortcut for device filter
- > 12/ 5 Add new shortcut for Assist dialog
- > 12/ 6 Use typed config entry in SABnzbd coordinator
- > 12/ 7 Show in assist pipeline debug when intent is preferred and processed locally
- > 12/ 8 Track if intent was processed locally
- > 12/ 9 Explicitly set file name for camera snapshot
- > 12/ 10 Add toggle switch for exposing of new entities to Assist
- > 12/ 11 Revert translation change for device quick bar
- > 12/ 12
- > 12/ 13
- > 12/ 14
- > 12/ 15
- > 12/ 16
- > 12/ 17
- > 12/ 18
- > 12/ 19
- > 12/ 20
- > 12/ 21
- > 12/ 22
- > 12/ 23
- > 12/ 24
-
> 12/ 25 Happy Holidays
Revert translation change for device quick bar
Proposed change
Revert the translation change for the device quick bar as it breaks the current translations for the release.
/cc @bramkragten
Type of change
<!-- What type of change does your PR introduce to the Home Assistant frontend? NOTE: Please, check only 1! box! If...
Add toggle switch for exposing of new entities to Assist
Proposed change
Added a toggle switch to disable the exposure of new entities for Assist. As far as I saw core already supports this, but there was no possibility in the frontend so far.
WTH: https://community.home-assistant.io/t/wth-are-all-new-entities-exposed-to-assist-by-default/803889...
Explicitly set file name for camera snapshot
Proposed change
Explicitly set file name for the camera snapshot in the more info dialog, instead of relaying on the browser.
Type of change
<!-- What type of change does your PR introduce to the Home Assistant frontend? NOTE: Please, check only 1! box! If your PR requires mul...
Show in assist pipeline debug when intent is preferred and processed locally
Proposed change
Show on the assist pipeline debug page if a run was processed locally and if the pipeline prefers local processing.
Core PR: https://github.com/home-assistant/core/pull/132166
#...
Track if intent was processed locally
Proposed change
Track if a intent was processed locally, this way we can show it on the assist pipeline debug page
Type of change
<!-- What type of change does your PR introduce to Home Assistant? NOTE: Please, check only 1! box! If your PR requires multiple boxes to be checke...
Use typed config entry in SABnzbd coordinator
Proposed change
Use typed config entry in SABnzbd coordinator, noticed in https://github.com/home-assistant/core/pull/131656
Type of change
<!-- What type of change does your PR introduce to Home Assistant? NOTE: Please, check only 1! box! If your PR requires multiple boxes ...
Add new shortcut for Assist dialog
<!-- You are amazing! Thanks for contributing to our project! Please, DO NOT DELETE ANY TEXT from this template! (unless instructed).
Before submitting your pull request, please verify that you have chosen the correct target branch, and that the PR preview looks fine and does not in...
Add new shortcut for device filter
<!-- You are amazing! Thanks for contributing to our project! Please, DO NOT DELETE ANY TEXT from this template! (unless instructed).
Before submitting your pull request, please verify that you have chosen the correct target branch, and that the PR preview looks fine and does not in...
Mark trend sensor unavailable when source entity is unknown/unavailable
Proposed change
Mark the trend binary sensor unavailable when the source entity is unavailable or unknown.
Type of change
<!-- What type of change does your PR introduce to Home Assistant? NOTE: Please, check only 1! box! If your PR requires multiple boxes to be checked, you'l...
Add device search to quick bar
Proposed change
Add devices to the quick bar, which is accessible through a shortcut (key D). The click on the device row navigates directly to the device detail page.
WTH: https://community.home-assistant.io/t/wth-is-there-no-quick-bar-for-devices/802310
 to open the voice assist dialog on every page.
WTH: https://community.home-assistant.io/t/wth-there-is-no-hotkey-for-assist/802403
Type of change
<!-- What type of change does your PR introduce to the Home Assistant frontend? NOTE: Please...
Add consider home interval to ping
Proposed change
After switching ping to config flow, the option to set the consider home interval was lost. This PR adds it back as an option via options flow.
I don't know if this should be included in version 2023.12, but since it's a new feature, I don't think so.
Type of change
...
Migrate geo_rss_events test to use freezegun
Proposed change
SSIA
Type of change
<!-- What type of change does your PR introduce to Home Assistant? NOTE: Please, check only 1! box! If your PR requires multiple boxes to be checked, you'll most likely need to split it into multiple PRs. This makes things easier and fast...
Make season types translatable
Proposed change
SSIA
Type of change
<!-- What type of change does your PR introduce to Home Assistant? NOTE: Please, check only 1! box! If your PR requires multiple boxes to be checked, you'll most likely need to split it into multiple PRs. This makes things easier and fa...
Remove device from known_devices upon import in ping device tracker
Proposed change
If the YAML is imported via the config flow and the device still exists in known_devices.yaml, the config entry will suffix the new entity with _2 as the entity is already used by the device_tracker platform which restores the entities from known_devices.yaml on restar...
Modernize and cleanup trend tests
Proposed change
This modernizes and cleans up the trend tests to use more fixtures and makes use of parametrize for identical tests.
This is a preparation for https://github.com/home-assistant/core/pull/99761
Type of change
<!-- What type of change does your PR introduce to Hom...
CLOUDFLARE: clear domainIndex after domain was created
Reset the domainIndex after the domain has been created at Cloudflare so that the following functions can fetch a new list of nameservers.
This fixes https://github.com/StackExchange/dnscontrol/issues/2652
Use freezegun in utility_meter tests
Proposed change
SSIA
Type of change
<!-- What type of change does your PR introduce to Home Assistant? NOTE: Please, check only 1! box! If your PR requires multiple boxes to be checked, you'll most likely need to split it into multiple PRs. This makes things easier and fast...
Use freezegun in cert_expiry tests
Proposed change
Make use of freezegun instead of patching utcnow directly in cert_expiry tests
Type of change
<!-- What type of change does your PR introduce to Home Assistant? NOTE: Please, check only 1! box! If your PR requires multiple boxes to be checked, you'll most lik...
Migrate non-component tests to use freezegun/freezer
Proposed change
Migrate the non-component to make use of freezegun/freezer instead of patching homeassistant.util.dt.* directly.
Should I better split this into multiple PRs?
Type of change
<!-- What type of change does your PR introduce to Home Assistant? NOTE: Please, check ...
Increase ping update interval to 30 seconds
Proposed change
After some discussion with the core dev team, 15 seconds are too fast, especially with external services. Thus set the interval to 30 seconds, which is seems to be a good compromise between fast and not overloading things
Type of change
<!-- What type of change does...
Migrate auth tests to use freezegun
Proposed change
Migrate the auth tests to make use of freezegun instead of directly patching homeassistant.util.dt.utcnow.
Type of change
<!-- What type of change does your PR introduce to Home Assistant? NOTE: Please, check only 1! box! If your PR requires multiple boxes ...
Explicit check for None in Discovergy entity if condition
Proposed change
Explicit check for None in the if condition, otherwise the sensors are not added or are not available later if they have 0.0 as value.
Type of change
<!-- What type of change does your PR introduce to Home Assistant? NOTE: Please, check only 1! box! If your...
Migrate samsungtv tests to use freezegun
Proposed change
Migrate the samsungtv tests to use freezegun instead of directly patching homeassistant.util.dt.utcnow
Type of change
<!-- What type of change does your PR introduce to Home Assistant? NOTE: Please, check only 1! box! If your PR requires multiple boxes to b...
Revert "Set default ping interval to 15 seconds instead 5 minutes"
Proposed change
Reverts home-assistant/home-assistant.io#30192 as it was the wrong branch, didn't know that current immediately goes live.
Type of change
<!--
What types of changes does your PR introduce to our documentation/website?
Put an x in the boxes that apply. You ca...
Migrate homeassistant component tests to use freezegun
Proposed change
Migrate the tests of the homeassistant component to use freezegun instead of patching homeassistant.util.dt.utcnow directly
Type of change
<!-- What type of change does your PR introduce to Home Assistant? NOTE: Please, check only 1! box! If your PR require...
Migrate octoprint tests to use freezegun
Proposed change
Migrate octoprint tests to use freezegun
Type of change
<!-- What type of change does your PR introduce to Home Assistant? NOTE: Please, check only 1! box! If your PR requires multiple boxes to be checked, you'll most likely need to split it into multiple PR...
Migrate sonarr tests to use freezegun
Proposed change
SSIA
Type of change
<!-- What type of change does your PR introduce to Home Assistant? NOTE: Please, check only 1! box! If your PR requires multiple boxes to be checked, you'll most likely need to split it into multiple PRs. This makes things easier and fa...
Migrate gree tests to use freezegun
Proposed change
Migrate gree tests to use freezegun instead of directly patching homeassistant.util.dt.utcnow
Type of change
<!-- What type of change does your PR introduce to Home Assistant? NOTE: Please, check only 1! box! If your PR requires multiple boxes to be checked, ...
Migrate unifi tests to use freezegun
Proposed change
Migrate unifi tests to use freezegun
Type of change
<!-- What type of change does your PR introduce to Home Assistant? NOTE: Please, check only 1! box! If your PR requires multiple boxes to be checked, you'll most likely need to split it into multiple PRs. T...
Migrate tag & tts tests to use freezegun
Proposed change
Migrate tag & tts tests to make use of freezegun instead of directly patching homeassistant.util.dt.utcnow
Type of change
<!-- What type of change does your PR introduce to Home Assistant? NOTE: Please, check only 1! box! If your PR requires multiple boxes ...
Migrate time_date tests to use freezegun
Proposed change
SSIA
Type of change
<!-- What type of change does your PR introduce to Home Assistant? NOTE: Please, check only 1! box! If your PR requires multiple boxes to be checked, you'll most likely need to split it into multiple PRs. This makes things easier and fast...
Update ping interval to 15 seconds
Proposed change
Update the ping interval to 15 seconds as this has been lowered with https://github.com/home-assistant/core/pull/105191
Type of change
<!--
What types of changes does your PR introduce to our documentation/website?
Put an x in the boxes that apply. You can...
Migrate template tests to use freezegun
Proposed change
Migrate template tests to use freezegun
Type of change
<!-- What type of change does your PR introduce to Home Assistant? NOTE: Please, check only 1! box! If your PR requires multiple boxes to be checked, you'll most likely need to split it into multiple PRs...
Migrate mqtt tests to use freezegun
Proposed change
Migrate the mqtt tests to make use of freezegun instead of directly patchin dt.utcnow
Type of change
<!-- What type of change does your PR introduce to Home Assistant? NOTE: Please, check only 1! box! If your PR requires multiple boxes to be checked, you'll...
Migrate roku tests to use freezegun
Proposed change
Migrate roku tests to use freezegun instead of patching util.dt.utcnow
Type of change
<!-- What type of change does your PR introduce to Home Assistant? NOTE: Please, check only 1! box! If your PR requires multiple boxes to be checked, you'll most likely need...
Migrate roku tests to use freezegun
Proposed change
Migrate roku tests to use freezegun instead of patching util.dt.utcnow
Type of change
<!-- What type of change does your PR introduce to Home Assistant? NOTE: Please, check only 1! box! If your PR requires multiple boxes to be checked, you'll most likely need...
Migrate geonetnz_* tests to use freezegun
Proposed change
Migrate the geonetnz_* tests to freezegun
Type of change
<!-- What type of change does your PR introduce to Home Assistant? NOTE: Please, check only 1! box! If your PR requires multiple boxes to be checked, you'll most likely need to split it into multiple P...
Migrate device_sun_light_trigger tests to use freezegun
Proposed change
Move the device_sun_light_trigger tests to use freezegun
Type of change
<!-- What type of change does your PR introduce to Home Assistant? NOTE: Please, check only 1! box! If your PR requires multiple boxes to be checked, you'll most likely need to split it ...
Migrate google related tests to use freezegun
Proposed change
Migrate google, google_assistant and nest tests to use freezegun
Type of change
<!-- What type of change does your PR introduce to Home Assistant? NOTE: Please, check only 1! box! If your PR requires multiple boxes to be checked, you'll most likely need t...
Migrate homematicip_cloud tests to use freezegun
Proposed change
SSIA
Type of change
<!-- What type of change does your PR introduce to Home Assistant? NOTE: Please, check only 1! box! If your PR requires multiple boxes to be checked, you'll most likely need to split it into multiple PRs. This makes things easier and fa...
Migrate demo test to use freezegun
Proposed change
SSIA
Type of change
<!-- What type of change does your PR introduce to Home Assistant? NOTE: Please, check only 1! box! If your PR requires multiple boxes to be checked, you'll most likely need to split it into multiple PRs. This makes things easier and fast...
Use snapshot assertion in homekit_controller diagnostics tests
Proposed change
SSIA, makes the test_diagnostics.py of homekit_controller more readable.
Type of change
<!-- What type of change does your PR introduce to Home Assistant? NOTE: Please, check only 1! box! If your PR requires multiple boxes to be checked, you'll most likely ...
Migrate homekit_controller tests to use freezegun
Proposed change
Migrate the homekit_controller tests to use freezegun.
TIL: It is important how the fixtures of the test function are ordered. The fixtures of the diagnostic tests must be reordered so that the time is frozen when we create the token for the hass_client.
Type of cha...
Add exception translations to rest_command
Breaking change
RESTful command service calls now raises errors when a timeout, non-200 response or unknown error occurs instead of failing silently. Please update your automations and use continue_on_error where necessary.
Proposed change
Add exceptions and translations to the rest...
Raise translatable exceptions in entity set methods for BSBLan
Proposed change
Raise translatable exceptions in the climate entity set methods for BSBLan instead of just logging them.
But I'm not 100% sure if ServiceValidationError is the right one in this case.
Type of change
<!-- What type of change does your PR introduce to Home Assistant...
Add missing rest_command reload service to services.yaml
Proposed change
The reload service of rest_command was missing in the services.yaml thus the YAML wasn't reloaded when a whole YAML reload was triggered.
Type of change
<!-- What type of change does your PR introduce to Home Assistant? NOTE: Please, check only 1! box! If y...
Remove gree switch entity description required fields mixin
Proposed change
SSIA
Type of change
<!-- What type of change does your PR introduce to Home Assistant? NOTE: Please, check only 1! box! If your PR requires multiple boxes to be checked, you'll most likely need to split it into multiple PRs. This makes things easier and fast...
Remove sun entity description required fields mixin
Proposed change
SSIA
Type of change
<!-- What type of change does your PR introduce to Home Assistant? NOTE: Please, check only 1! box! If your PR requires multiple boxes to be checked, you'll most likely need to split it into multiple PRs. This makes things easier and fast...
Migrate directv test to use freezegun
Proposed change
SSIA
Type of change
<!-- What type of change does your PR introduce to Home Assistant? NOTE: Please, check only 1! box! If your PR requires multiple boxes to be checked, you'll most likely need to split it into multiple PRs. This makes things easier and fast...
Migrate file test to use freezegun
Proposed change
SSIA
Type of change
<!-- What type of change does your PR introduce to Home Assistant? NOTE: Please, check only 1! box! If your PR requires multiple boxes to be checked, you'll most likely need to split it into multiple PRs. This makes things easier and fast...
Add unban_ip service to http documentation
Proposed change
This adds the new unban_ip service to the http component documentation.
Type of change
<!--
What types of changes does your PR introduce to our documentation/website?
Put an x in the boxes that apply. You can also fill these out after
creating the...
Add unban_ip service to http
Proposed change
This adds a new service called unban_ip to the http component to unban previously banned IP addresses without the need of touching the YAML or restarting Home Assistant. It removes the IP address from the in-memory ban list and then writes it to the disc.
This way a us...
Use constants instead of literals for api
Proposed change
Use constants from http instead of literals in api.
Type of change
<!-- What type of change does your PR introduce to Home Assistant? NOTE: Please, check only 1! box! If your PR requires multiple boxes to be checked, you'll most likely need to split it i...
Add myself as code owner for rest_command
Proposed change
I saw by chance (actually as I use it myself) that rest_command has no code owner, so I decided to step up as one.
Type of change
<!-- What type of change does your PR introduce to Home Assistant? NOTE: Please, check only 1! box! If your PR requires multiple ...
Use freezegun in image_upload test
Proposed change
Use freezegun in image_upload test instead of directly patch utcnow
Type of change
<!-- What type of change does your PR introduce to Home Assistant? NOTE: Please, check only 1! box! If your PR requires multiple boxes to be checked, you'll most likely nee...
Use freezegun in ign_sismologia test
Proposed change
Make use of freezegun instead of directly patching utcnow
Type of change
<!-- What type of change does your PR introduce to Home Assistant? NOTE: Please, check only 1! box! If your PR requires multiple boxes to be checked, you'll most likely need to sp...
Use freezegun in nsw_rural_fire_service_feed test
Proposed change
Make use of freezegun instead of patching utcnow directly
Type of change
<!-- What type of change does your PR introduce to Home Assistant? NOTE: Please, check only 1! box! If your PR requires multiple boxes to be checked, you'll most likely need to spli...
Use freezegun in qld_bushfire test
Proposed change
Make use of freezegun instead of patching utcnow directly.
Type of change
<!-- What type of change does your PR introduce to Home Assistant? NOTE: Please, check only 1! box! If your PR requires multiple boxes to be checked, you'll most likely need to spl...
Remove ipma entity description required fields mixin
Proposed change
SSIA
Type of change
<!-- What type of change does your PR introduce to Home Assistant? NOTE: Please, check only 1! box! If your PR requires multiple boxes to be checked, you'll most likely need to split it into multiple PRs. This makes things easier and fast...
Use call_soon_threadsafe in face processing of image_processing
Proposed change
As in https://github.com/home-assistant/core/pull/106137, we have used run_callback_threadsafe here, which has the overhead of creating a future. Since we throw it away anyway and we don't have to wait for the result (since the called function only generates an event), we ca...
Remove gios sensor description required fields mixin
Proposed change
Remove the sensor description required fields mixin to make it more readable and comply with the recent changes (https://developers.home-assistant.io/blog/2023/12/11/entity-description-changes/)
Type of change
<!-- What type of change does your PR introduce to Home A...
Add reference to ping options
Proposed change
Add a reference to the ping options, the existing ping count and the newly added consider home interval (https://github.com/home-assistant/core/pull/104881).
Type of change
<!-- What types of changes does your PR introduce to our documentation/website? Put an ...
Remove unnecessary async_add_job in face processing of image_processing
Proposed change
As mentioned in https://github.com/home-assistant/core/pull/106168#pullrequestreview-1793788268 the self.hass.async_add_job call is also unnecessary, as the function itself is already running in the event loop, so remove it.
I need to cast face to dict here otherwise ...
Add Roborock S7 MaxV Ultra station sensors
This PR adds two sensors of the auto-emptying and washing station of the Roborock S7 MaxV.
Add mop dryer add-on of the S7 MaxV Ultra station
The S7 MaxV Ultra Station has an optional mop dryer add-on. Based on reverse engineering of the Mi Home app plugin code, I added support for this.
Currently this code is partially untested as I am waiting for my add-on to be delivered. Delivery is expected around 12/19.
But I appreciate cod...
Decrease minimum temperature change for SONOFF SNZB-02
Decrease the minimum temperature change the is reported, so the SONOFF SNZB-02 reports the temperature sooner. This would fix the issue described at https://www.zigbee2mqtt.io/devices/SNZB-02.html.
Already tested this with my SNZB-02 sensor.
sFlow decode when enterprise id is 0
Detected some unexpected behavior with e.g. pmacct
pmacct is using enterpriseID 43874 and flowRecordType 2 for something different which causes problems.
Try to decode sflow records, only when enterprise id is 0, which signals that it using the default structs according to the specification.
added support for sflow ethernet frame flows
Added support for sFlow ethernet frame flows