24 Pull Requests
duncanmcclean

duncanmcclean

Preferred Languages
CSS
HTML
JavaScript
Markdown
PHP
Member of...
  • statamic
duncanmcclean has made 13 contributions so far during the 2023 holidays
  • Gifts
  • Contributions
  • 2022
  • 2021
  • 2020
  • 2019
  • 2018
  • 2017
  • 2016
  • 2015
  • 2014
  • 2013
  • 2012
  1. > 12/ 1 [6.x] Ensure parent is passed into fields in publish forms
  2. > 12/ 2 [5.x] Fix fields parent not being passed on publish forms
  3. > 12/ 3 [4.x] Fix replicator preview for Date fieldtype when time is empty
  4. > 12/ 4 [4.x] Fix "Hide Display" setting not being persisted on reference field
  5. > 12/ 5 Document adding computed values to multiple collections
  6. > 12/ 6 Nocache tag: Document the new `select` parameter
  7. > 12/ 7 [4.x] Run Laravel Pint
  8. > 12/ 8 Document PR: Apply scopes to query builders
  9. > 12/ 9 [4.x] Fix tree view when configuring collection mount
  10. > 12/ 10 [4.x] "Configure asset containers" permission should override other
  11. > 12/ 11 [4.x] Exclude taxonomy index pages from nav:breadcrumbs tag when view is missing
  12. > 12/ 12 [4.x] Fix disabled save button when creating term inside term inside stack
  13. > 12/ 13 [4.x] Fix Ignition Solutions
  14. > 12/ 14
  15. > 12/ 15
  16. > 12/ 16
  17. > 12/ 17
  18. > 12/ 18
  19. > 12/ 19
  20. > 12/ 20
  21. > 12/ 21
  22. > 12/ 22
  23. > 12/ 23
  24. > 12/ 24
  25. > 12/ 25 Happy Holidays

[4.x] Fix Ignition Solutions to statamic/cms 2023-12-07 15:24:45 UTC

This pull request fixes Ignition Solutions after they stopped working when the namespace changed from Facade\... to Spatie\....

[4.x] Exclude taxonomy index pages from nav:breadcrumbs tag when view is missing to statamic/cms 2023-12-07 13:33:07 UTC

This pull request excludes taxonomy index pages from being returned by the {{ nav:breadcrumbs }} tag when the index view is missing.

An attempt was made in #4147 to fix this but it implemented a new view_exists variable, instead of filtering the page out of the breadcrumbs like this PR doe...

[4.x] Fix disabled save button when creating term inside term inside stack to statamic/cms 2023-12-07 13:04:59 UTC

This pull request attempts to fix an issue where the "Save" button on a term's inline publish form would be disabled if you had created another term inside that publish form...

If that description doesn't make any sense, watch the video in #8308 which will describe it nice and clear 😆

Whe...

[4.x] "Configure asset containers" permission should override other to statamic/cms 2023-12-06 17:01:06 UTC

This pull request fixes an issue where the "configure asset containers" permission doesn't override other asset permissions (like the ability to upload assets or create folders).

Fixes #7382.

[4.x] Fix tree view when configuring collection mount to statamic/cms 2023-12-05 23:44:33 UTC

This pull request fixes an issue when selecting an entry to mount a collection onto. It would only happen when a site has 2 collections (eg. Pages & News) and the user is viewing the new "Tree View".

No site was being passed down the chain to the PageTree so the tree that was returned from t...

Document PR: Apply scopes to query builders to statamic/docs 2023-12-05 21:59:49 UTC

Note: This should only be merged after statamic/cms#5927 has been merged & tagged.

This pull request documents the ability to apply query scopes when using Statamic's query builder.

Related: statamic/cms#5927

Nocache tag: Document the new `select` parameter to statamic/docs 2023-12-05 20:59:41 UTC

Note: This PR should be held until v4.39.0 has been merged.

This pull request documents the new select parameter that's been added to the {{ nocache }} tag recently.

Related: statamic/cms#9124

[4.x] Run Laravel Pint to statamic/cms 2023-12-05 20:06:05 UTC

This pull request runs Laravel Pint after a linting change in the latest version of Pint (v1.13.7) caused 50 file changes. 😅

Document adding computed values to multiple collections to statamic/docs 2023-12-04 16:25:28 UTC

Documents the changes in statamic/cms#7165

[4.x] Fix "Hide Display" setting not being persisted on reference field to statamic/cms 2023-12-04 11:41:59 UTC

This pull request fixes an issue where changes to the "Hide Display" setting in the blueprint builder weren't being persisted back to the blueprint's YAML file when editing a "reference field".

This was caused by hide_display being updated on the publish container without the updateField m...

[6.x] Ensure parent is passed into fields in publish forms to duncanmcclean/runway 2023-12-01 11:04:37 UTC

This pull request fixes an issue where Runway wasn't passing the Eloquent model as the "parent" into the fields when on publish form pages.

The parent can be helpful when developing custom fieldtype as it provides some context about the "thing" thats being edited.

Mirrors #381 but for v6.

[5.x] Fix fields parent not being passed on publish forms to duncanmcclean/runway 2023-12-01 10:56:48 UTC

This pull request fixes an issue where Runway wasn't passing the Eloquent model as the "parent" into the fields when on publish form pages.

The parent can be helpful when developing custom fieldtype as it provides some context about the "thing" thats being edited.

Fixes #379.

[4.x] Fix replicator preview for Date fieldtype when time is empty to statamic/cms 2023-12-01 10:33:01 UTC

This pull request follows on from #9093, by fixing an issue with the Date fieldtype's replicator preview. When the time value was left empty, null would be returned in the replicator preview.

Related: https://github.com/statamic/cms/issues/9088#issuecomment-1835678901

Before

![Clean...

Fix Duplicator not respecting collections without slugs to statamic/cms 2022-12-16 21:54:42 UTC

This pull request fixes #7166 by only setting slugs on duplicated entries if the collection has the 'Requires Slugs' toggle enabled.

Previously, it would generate filenames like 1.md when you duplicate entries on a collection where the setting wasn't enabled.

This was happening because o...

Allow for translating order emails to duncanmcclean/simple-commerce 2022-12-16 21:12:05 UTC

This pull request makes it possible to translate the order emails that are sent automatically by Simple Commerce.

All of the 'strings' in the order emails are wrapped in Laravel's __() helper - allowing for the individual strings to be overridden in a lang/{locale}.json file like this:

...

Order results by name (Collection & Taxonomy fieldtypes) to statamic/cms 2022-12-17 14:05:31 UTC

This pull request closes #6908 by ordering the list of collections/taxonomies alphabetically by name.

Apply fixes from StyleCI to duncanmcclean/runway 2022-12-21 15:57:28 UTC

This pull request applies code style fixes from an analysis carried out by StyleCI.


For more information, click here.

Winter Tidy-up 🧹 to duncanmcclean/runway 2022-12-21 15:56:26 UTC

This pull request makes some very minor changes - like adding type hints to methods & adding comments for some of the more complicated bits of the Runway codebase.

It also removes one of the old upgrade scripts left over from the v1 -> v2 upgrade.

Fix error with BelongsTo fieldtype when saving via a publish form inside a stack to duncanmcclean/runway 2022-12-07 00:31:27 UTC

This pull request resolves an issue where saving a record via a publish form inside a stack would fail when the resource inside the stack includes a BelongsTo field.

  • So say, you had a 'Locations' resource.
  • When editing locations, you can create/edit 'Location Updates'
  • The Location Upd...

Use configuration option as pagination size default to statamic/cms 2022-12-03 15:27:38 UTC

This pull request fixes #7160.

Previously, there was a configuration option in the API config file for pagination size. However, it wasn't actually being used as the default when making API requests.

Now, it is being used 😄

Apply fixes from StyleCI to doublethreedigital/static-cache-manager 2021-12-11 18:07:18 UTC

This pull request applies code style fixes from an analysis carried out by StyleCI.


For more information, click here.

Apply fixes from StyleCI to doublethreedigital/runway 2021-12-11 18:03:55 UTC

This pull request applies code style fixes from an analysis carried out by StyleCI.


For more information, click here.

Provide default values for custom option fields to doublethreedigital/simple-commerce 2021-12-13 12:19:12 UTC

Description

<!-- What does this PR change? Has it added anything new? What has it fixed? -- Maybe provide a few screenshots, a Loom (https://loom.com) or a code snippet? -->

This pull request resolves an issue where custom option fields wouldn't behave as expected prior to them ...

Apply fixes from StyleCI to doublethreedigital/yumyum 2021-12-13 09:20:14 UTC

This pull request applies code style fixes from an analysis carried out by StyleCI.


For more information, click here.

Apply fixes from StyleCI to doublethreedigital/sc-starter-kit 2021-12-11 18:09:17 UTC

This pull request applies code style fixes from an analysis carried out by StyleCI.


For more information, click here.

Apply fixes from StyleCI to doublethreedigital/sc-digital-products 2021-12-11 18:08:49 UTC

This pull request applies code style fixes from an analysis carried out by StyleCI.


For more information, click here.

Fix off-site gateways not updating stock counts to doublethreedigital/simple-commerce 2021-12-13 11:11:20 UTC

Description

<!-- What does this PR change? Has it added anything new? What has it fixed? -- Maybe provide a few screenshots, a Loom (https://loom.com) or a code snippet? -->

This pull request fixes an issue where stock counts would not be updated after customers checkout with an...

Apply fixes from StyleCI to doublethreedigital/simple-commerce 2021-12-16 16:03:04 UTC

This pull request applies code style fixes from an analysis carried out by StyleCI.


For more information, click here.

Apply fixes from StyleCI to doublethreedigital/simple-commerce 2021-12-16 15:52:10 UTC

This pull request applies code style fixes from an analysis carried out by StyleCI.


For more information, click here.

Apply fixes from StyleCI to doublethreedigital/simple-commerce 2021-12-16 15:47:55 UTC

This pull request applies code style fixes from an analysis carried out by StyleCI.


For more information, click here.

v2.4: Different carts per site to doublethreedigital/simple-commerce 2021-12-16 21:20:33 UTC

Description

<!-- What does this PR change? Has it added anything new? What has it fixed? -- Maybe provide a few screenshots, a Loom (https://loom.com) or a code snippet? -->

This pull request introduces a change focused towards multi-site users.

Right now, if two sites are s...

Simplify gateway data to doublethreedigital/simple-commerce 2021-12-07 22:13:15 UTC

Description

<!-- What does this PR change? Has it added anything new? What has it fixed? -- Maybe provide a few screenshots, a Loom (https://loom.com) or a code snippet? -->

This pull request introduces a change which simplifies the way gateway data is stored. Previously, it wou...

Alphabetically order asset containers to statamic/cms 2021-12-21 18:45:25 UTC

This pull request fixes #4939.

The asset container 'tabs' shown on the Assets page are now ordered alphabetically and I've also fixed it so when you press the 'Assets' parent nav button, it'll go to the first container in alphabetical order.

Apply fixes from StyleCI to doublethreedigital/addon-boilerplate 2021-12-11 18:04:37 UTC

This pull request applies code style fixes from an analysis carried out by StyleCI.


For more information, click here.

Apply fixes from StyleCI to doublethreedigital/simple-commerce 2021-12-13 09:16:11 UTC

This pull request applies code style fixes from an analysis carried out by StyleCI.


For more information, click here.

Apply fixes from StyleCI to doublethreedigital/duplicator 2021-12-11 18:05:11 UTC

This pull request applies code style fixes from an analysis carried out by StyleCI.


For more information, click here.

Apply fixes from StyleCI to doublethreedigital/social-shots 2021-12-11 18:10:00 UTC

This pull request applies code style fixes from an analysis carried out by StyleCI.


For more information, click here.

Apply fixes from StyleCI to doublethreedigital/simple-commerce 2021-12-11 18:09:52 UTC

This pull request applies code style fixes from an analysis carried out by StyleCI.


For more information, click here.

Apply fixes from StyleCI to doublethreedigital/guest-entries 2021-12-11 18:08:01 UTC

This pull request applies code style fixes from an analysis carried out by StyleCI.


For more information, click here.

Apply fixes from StyleCI to doublethreedigital/docs-starter-kit 2021-12-11 18:07:46 UTC

This pull request applies code style fixes from an analysis carried out by StyleCI.


For more information, click here.

Apply fixes from StyleCI to doublethreedigital/blaze 2021-12-11 18:06:14 UTC

This pull request applies code style fixes from an analysis carried out by StyleCI.


For more information, click here.

Apply fixes from StyleCI to doublethreedigital/cookie-notice 2021-12-11 18:05:37 UTC

This pull request applies code style fixes from an analysis carried out by StyleCI.


For more information, click here.

Apply fixes from StyleCI to doublethreedigital/simple-commerce 2021-12-16 15:45:42 UTC

This pull request applies code style fixes from an analysis carried out by StyleCI.


For more information, click here.

  • Sponsored by  DNSimple,  Octobox &  Bugsnag
  • About
  • How to contribute?
  • API
  • Unsubscribe
    •  English
    •  Español
    •  Ελληνικά
    •  Português do Brasil
    •  Suomi
    •  Français
    •  Deutsch
    •  Русский
    •  Українська
    •  ไทย
    •  Italiano
    •  Norsk bokmål
    •  தமிழ்
    •  Tr
    •  简体中文
    •  正體中文
    •  日本語
    •  Čeština
    •  हिंदी
    •  Polski
    • Translate into your language!